fix: set source name and category in the FluentD output for events #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I'll update the changelog after we release 2.7. In the meantime, this is ready for review. |
pmalek-sumo
suggested changes
Apr 7, 2022
sumo-drosiek
approved these changes
Apr 8, 2022
swiatekm
force-pushed
the
test/integration/events
branch
from
2cfedf7 to
2c55fda
Compare
added 2 commits
April 13, 2022 12:29
We've been setting it directly on the source in the setup Terraform manifest. Instead, do it in the output plugin and make it configurable. This makes it both easier to test and makes it work correctly if setup is disabled.
swiatekm
force-pushed
the
test/integration/events
branch
from
2c55fda to
f246ce3
Compare
pmalek-sumo
reviewed
Apr 13, 2022
pmalek-sumo
approved these changes
Apr 13, 2022
andrzej-stencel
added a commit
that referenced
this pull request
Jun 1, 2022
A bug was introduced in v2.8.0 (#2222) that made the `fluentd.events.sourceCategory` non-functional.
andrzej-stencel
added a commit
that referenced
this pull request
Jun 1, 2022
A bug was introduced in v2.8.0 (#2222) that made the `fluentd.events.sourceCategory` non-functional.
andrzej-stencel
added a commit
that referenced
this pull request
Jun 1, 2022
A bug was introduced in v2.8.0 (#2222) that made the `fluentd.events.sourceCategory` non-functional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been setting source name and category directly on the source in the setup Terraform manifest. Instead, do it in the output plugin and make it configurable.
This makes it both easier to test and makes it work correctly if setup is disabled.
Also add a basic integration test for events.
Checklist
Testing performed