chore: update Thanos to v0.25.2 #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
chore/update-thanos
branch
from
d75ae66 to
77159fa
Compare
|
Could you remove it from best practices doc please? |
swiatekm
force-pushed
the
chore/update-thanos
branch
from
77159fa to
ba48f1f
Compare
Done. |
sumo-drosiek
reviewed
May 5, 2022
deploy/docs/Best_Practices.md
Outdated
| @@ -1158,15 +1151,15 @@ to work with our collection. | |||
|
|
|||
| - add your custom prometheus configuration | |||
|
|
|||
| 1. [Upgrade sumologic chart](./Installation_with_Helm.md#upgrading-sumo-logic-collection) without `kube-prometheus-stack` | |||
| 2. [Upgrade sumologic chart](./Installation_with_Helm.md#upgrading-sumo-logic-collection) without `kube-prometheus-stack` | |||
There was a problem hiding this comment.
tbh, markdownlint should complain about it 😕
There was a problem hiding this comment.
There's a parameter for it: https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix but I think the default is permissive.
Thanos now has official ARM Docker images, so we can go back to using the upstream repository.
swiatekm
force-pushed
the
chore/update-thanos
branch
from
ba48f1f to
73e433f
Compare
sumo-drosiek
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanos now has official ARM Docker images, so we can go back to using the upstream repository.
Checklist