remove log_format, attach fields by default #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimaisie
reviewed
Oct 16, 2019
| if annotations["sumologic.com/sourceHost"].nil? | ||
| sumo_metadata[:host] = sumo_metadata[:host] % k8s_metadata | ||
| else | ||
| sumo_metadata[:host] = annotations["sumologic.com/sourceHost"] % k8s_metadata |
There was a problem hiding this comment.
good question - for default source name, we use something like %{namespace}.%{pod}.%{container}, so if k8s_metadata contains keys for namespace, pod, or container, it will populate those values so we get a final source name like sumologic.fluentd-xxx.fluentd or something like that
I believe this was how we supported dynamically populating metadata values in our sumo metadata.
maimaisie
reviewed
Oct 16, 2019
| # message ${begin; record["message"].merge(JSON.parse(record["message"]["log"])).delete("log"); rescue JSON::ParserError; record["message"]; end} | ||
| # </record> | ||
| # </filter> | ||
| <match containers.**> |
There was a problem hiding this comment.
did we want to add before and after examples for each filter here?
There was a problem hiding this comment.
good catch, will do that
maimaisie
approved these changes
Oct 16, 2019
samjsong
force-pushed
the
ssong-remove-log-format
branch
from
2617b69 to
30ee4c3
Compare
3 tasks
3 tasks
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Add WAF collector * Fmt * Add role and S3 source * Module role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recommend reviewing commit by commit (maybe also with "hide whitespace changes"), hopefully that makes it easier to read the changes
By removing the
log_formatconfig, the filter plugin now always attaches the metadata as_sumo_metadata.fields.We did get rid of
add_timestampin the output plugin, so the logs that come in no longer havetimestamp(but still havetime). We'll have to explicitly decide what we want to do by default to make those config changes in the fluentd yaml.TODO: use
sumologicoutput plugin version2.0.0in DockerFile when gem is released, once SumoLogic/fluentd-output-sumologic#53 is mergedTesting performed
sumologicoutput plugin to verify behaviour