Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling Fluentd #235

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Scaling Fluentd #235

merged 3 commits into from
Oct 17, 2019

Conversation

abhi-sumo-zz
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@samjsong samjsong requested a review from drduke1 October 16, 2019 22:14
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, nit: we should stay consistent with capitalization of things like Fluentd.

One thing I love about this is that it's in its own separate file - something we should do is split our existing monster of a readme into more manageable, easy to digest files like this one. They can link to each other the way we do in DocHub.

@samjsong samjsong merged commit 85672f4 into SumoLogic:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants