-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pvc-cleaner to the chart #2796
Conversation
66ced85
to
d5b3aa7
Compare
--- | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: Role | ||
metadata: | ||
name: {{ template "sumologic.metadata.name.pvc-cleaner.roles.serviceaccount" . }} | ||
rules: | ||
- apiGroups: | ||
- "" | ||
resources: | ||
- persistentvolumeclaims | ||
verbs: | ||
- get | ||
- list | ||
- delete | ||
- apiGroups: | ||
- "autoscaling" | ||
resources: | ||
- horizontalpodautoscalers | ||
verbs: | ||
- get | ||
- list | ||
- apiGroups: | ||
- "" | ||
resources: | ||
- pods | ||
verbs: | ||
- get | ||
- list | ||
|
||
--- | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: RoleBinding | ||
metadata: | ||
name: {{ template "sumologic.metadata.name.pvc-cleaner.roles.serviceaccount" . }} | ||
roleRef: | ||
apiGroup: rbac.authorization.k8s.io | ||
kind: Role | ||
name: {{ template "sumologic.metadata.name.pvc-cleaner.roles.serviceaccount" . }} | ||
subjects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was based on internal setup. Strangely enough, this wasn't necessary when tested manually, but integration tests didn't work without this role.
5f6009f
to
c0926d9
Compare
This is ready to review now, apart from one thing: |
Yeah, we already do the same thing for PDBs: https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/templates/_api_versions_helpers.tpl |
Integration tests are failing because of insufficient CPU, I'll try to merge the new test into one of the older ones. |
03bbd30
to
aa344fa
Compare
Integration tests work after lowering the cpu requests in |
aa344fa
to
3e919f7
Compare
3e919f7
to
042a3a1
Compare
I applied changes after review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored by: Adam Boguszewski <aboguszewski@sumologic.com>
1db1965
to
24882d5
Compare
This PR adds pvc-cleaner cronjobs to the helm chart. It's based on what @sumo-drosiek created on this branch.
Things done:
values.yaml
values.yaml
, description inbest-practices.md
)Resolves #2602