Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dockerfile Sumo TF provider to 2.0.0 #282

Merged
merged 4 commits into from
Nov 9, 2019

Conversation

rvmiller89
Copy link
Contributor

@rvmiller89 rvmiller89 commented Nov 8, 2019

Description

With the new TF provider, we no longer require specifying endpoint URL since it will try to follow the 301 redirection response to the correct deployment.

Testing performed
  • ci/build.sh
  • Local helm chart install with local built Docker image, specifying US2 access key/id but not specifying endpoint URL, verified the TF Provider automatically redirected and created collector and sources on US2 🎉
  • Confirm events, logs, and metrics are coming in

@@ -7,7 +7,7 @@ kind: ConfigMap
metadata:
name: collection-sumologic-setup
annotations:
"helm.sh/hook": pre-install
"helm.sh/hook": pre-install,pre-upgrade
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these generated changes were missed in #281 which may have been built using an older master with older build.sh script

@rvmiller89 rvmiller89 merged commit ada9e1f into master Nov 9, 2019
@rvmiller89 rvmiller89 deleted the rmiller-bump-dockerfile-tf-provider branch November 9, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants