feat(metrics): add ability to use OTLP source #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
2 times, most recently
from
d7bb601 to
fcb9561
Compare
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
from
fcb9561 to
f07a1b4
Compare
Comment on lines
343
to
353
| exporters: | ||
| - sumologic/default | ||
| {{- if eq .Values.sumologic.metrics.sourceType "http" }} | ||
| - sumologic/apiserver | ||
| - sumologic/control_plane | ||
| - sumologic/controller | ||
| - sumologic/kubelet | ||
| - sumologic/node | ||
| - sumologic/scheduler | ||
| - sumologic/state | ||
| {{- end }} |
There was a problem hiding this comment.
Will that work fine (without any blacklisting and throttling due to metrics cardinality)?
There was a problem hiding this comment.
I believe so. And if not, I think I'd rather put a hold on this PR instead of reproducing the 8 source setup in otlp. But from what I know, we're either there, or will be very soon.
There was a problem hiding this comment.
In the meantime, can you review these changes on the assumption that this ok to do?
There was a problem hiding this comment.
Yes, remaining changes looks fine for me
1 task
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
from
f07a1b4 to
620fc03
Compare
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
2 times, most recently
from
611ace8 to
3140422
Compare
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
4 times, most recently
from
ee95d73 to
2693b9b
Compare
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
6 times, most recently
from
b42763e to
a2df05d
Compare
swiatekm
force-pushed
the
feat/metrics/otlp-source
branch
from
a2df05d to
fae8c2e
Compare
sumo-drosiek
reviewed
Sep 6, 2023
sumo-drosiek
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting for switching to the OTLP source for metrics.
The source is created for all users with setup enabled, and the setting only controls if we're sending data to it. It's intentionally one source vs the 8 with have for HTTP, as I believe the technical reasons for the latter are no longer valid.
In terms of implementation, parts of the metrics pipeline become conditional.
Checklist