feat: use kubectl image for pvc cleaner #2973
Conversation
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
changed the title
sumo-drosiek
changed the title
| | `pvcCleaner.job.image.repository` | Image repository for pvcCleaner docker containers. | `public.ecr.aws/sumologic/kubernetes-tools` | | ||
| | `pvcCleaner.job.image.tag` | Image tag for pvcCleaner docker containers. | `2.15.0` | | ||
| | `pvcCleaner.job.image.repository` | Image repository for pvcCleaner docker containers. | `public.ecr.aws/sumologic/kubectl` | | ||
| | `pvcCleaner.job.image.tag` | Image tag for pvcCleaner docker containers. | `1.26.3` | |
There was a problem hiding this comment.
Technically, that sounds like a breaking change (although I doubt that many customers are using it now), do we have any procedures for that?
There was a problem hiding this comment.
It is breaking change, as we change mount property of the pod. I don't think we have any procedure for that. We can add warning message for helm chart before 3.5.0 with ask for customers to remove the current jobs
There was a problem hiding this comment.
Sounds good, but I guess that it still should be discussed once @perk-sumo is back.
There was a problem hiding this comment.
I don't completely understand why this is a breaking change. Because we add a new volume? I suppose someone could build their own version of the tools image and put something there, but that seems farfetched. What kind of configuration would this break?
There was a problem hiding this comment.
If someone changed the image tag, for example.
I doubt someone is using this with overridden image tag or image name, but still.
There was a problem hiding this comment.
Because we add a new volume?
volumeMount is immutable in k8s
There was a problem hiding this comment.
I double checked and pod spec in cronjob doesn't seem to be immutable (at least volume configuration is not)
There was a problem hiding this comment.
If someone changed the image tag, for example.
I doubt someone is using this with overridden image tag or image name, but still.
If you use a different tools image version, this will still work - the only requirements are bash and kubectl. If someone put something completely custom here, I don't think we support that.
It is already https://github.com/SumoLogic/sumologic-kubernetes-collection/actions/runs/4636802238/jobs/8205047669?pr=2973 |
The motivation is to use the minimal image required to provide the functionality and I propose to use bitnami/kubectl
Checklist