-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel statefulset cloudwatch collector #2982
Conversation
a361d8a
to
3cf0db0
Compare
7545d01
to
8fcc775
Compare
fe92282
to
142c27b
Compare
cf3f1af
to
b8b8e42
Compare
deploy/helm/sumologic/templates/logs/collector/otelcol-cloudwatch/statefulset.yaml
Show resolved
Hide resolved
deploy/helm/sumologic/templates/logs/collector/otelcol-cloudwatch/statefulset.yaml
Outdated
Show resolved
Hide resolved
deploy/helm/sumologic/templates/logs/collector/otelcol/serviceaccount.yaml
Outdated
Show resolved
Hide resolved
Some additional thoughts after using this:
sumologic:
logs:
collector:
otelcloudwatch:
awscloudwatch:
logs:
groups:
named:
fluent-bit-cloudwatch:
names: ["some-name"] and it raised an error, because the default is also using
|
tests/helm/testdata/goldenfile/logs_otc_serviceaccount/basic.output.yaml
Outdated
Show resolved
Hide resolved
…r configuration and fargate prerequisites
deploy/helm/sumologic/templates/logs/collector/otelcol-cloudwatch/configmap.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overally LGTM, some minor minor comments
45f6f66
to
eed8faa
Compare
I've made the suggested changes, will keep this documentation task below open: https://jira.kumoroku.com/jira/browse/SUMO-205563 Added the comment from this PR to the above ticket: #2982 (comment) |
deploy/helm/sumologic/values.yaml
Outdated
statefulset: | ||
nodeSelector: {} | ||
tolerations: [] | ||
topologySpreadConstraints: [] | ||
affinity: {} | ||
## Acceptable values for podAntiAffinity: | ||
## soft: specifies preferences that the scheduler will try to enforce but will not guarantee (Default) | ||
## hard: specifies rules that must be met for a pod to be scheduled onto a node | ||
podAntiAffinity: "soft" | ||
replicaCount: 1 | ||
resources: | ||
limits: | ||
memory: 1Gi | ||
cpu: 1000m | ||
requests: | ||
memory: 768Mi | ||
## Warning! Increasing the CPU requests for Fluentd above 1000m might result in broken autoscaling | ||
## ref: https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/docs/best-practices.md#cpu-resources-warning | ||
cpu: 500m | ||
## Option to define priorityClassName to assign a priority class to pods. | ||
priorityClassName: | ||
|
||
## Add custom labels only to logs otel sts pods | ||
podLabels: {} | ||
## Add custom annotations only to logs otel sts pods | ||
podAnnotations: {} | ||
## Set securityContext for containers running in pods in otelcol-instrumentation statefulset. | ||
containers: | ||
otelcol: | ||
securityContext: {} | ||
livenessProbe: | ||
initialDelaySeconds: 15 | ||
periodSeconds: 15 | ||
timeoutSeconds: 10 | ||
failureThreshold: 3 | ||
readinessProbe: | ||
initialDelaySeconds: 5 | ||
periodSeconds: 10 | ||
timeoutSeconds: 3 | ||
failureThreshold: 3 | ||
startupProbe: | ||
periodSeconds: 3 | ||
failureThreshold: 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please doucment it in README as github actions are failing, also, I think it's not otellogs
anymore, eventually otellogs.cloudwatch
or otelcloudwatch
247d59e
to
3e07acc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3e07acc
to
a730e0f
Compare
a730e0f
to
6e146de
Compare
This PR creates a statefulset for collecting logs from cloudwatch. It also documents some of the steps needed to setup log ingestion from cloudwatch. The fargate readme has been updated with some details
It has initial documentation on how to set this up
The changes have been tested on a fargate cluster, with logs being ingested into sumo
there isn't any processing or metadata enrichment yet
There's a basic template test, integration tests are pending
https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/otel-statefulset-collector/docs/fargate.md#logs
Checklist