Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otellogs): configure imagePullSecrets for otellogs daemonset #2984

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

kasia-kujawa
Copy link
Contributor

@kasia-kujawa kasia-kujawa commented Apr 13, 2023

Pull request was tested manually with following configuration:

sumologic:
  accessId: dummy
  accessKey: dummy
  endpoint: http://receiver-mock.receiver-mock:3000/terraform/api/
  pullSecrets:
    - name: container-secret-test

otellogs:
  image:
    repository: ghcr.io/kkujawa-sumo/sumologic-otel-collector
    tag: "0.73.0-sumo-1"
  daemonset:
    initContainers:
      changeowner:
        image:
          repository: ghcr.io/kkujawa-sumo/busybox
          tag: 1.36.0
          pullPolicy: IfNotPresent

new ServiceAccount:

$ kubectl get ServiceAccounts -n sumologic collection-sumologic-otelcol-logs-collector -o yaml
apiVersion: v1
imagePullSecrets:
- name: container-secret-test
kind: ServiceAccount
metadata:
  annotations:
    meta.helm.sh/release-name: collection
    meta.helm.sh/release-namespace: sumologic
  creationTimestamp: "2023-04-14T09:46:26Z"
  labels:
    app: collection-sumologic-otelcol-logs-collector
    app.kubernetes.io/managed-by: Helm
    chart: sumologic-3.4.0
    heritage: Helm
    release: collection
  name: collection-sumologic-otelcol-logs-collector
  namespace: sumologic
  resourceVersion: "105439"
  selfLink: /api/v1/namespaces/sumologic/serviceaccounts/collection-sumologic-otelcol-logs-collector
  uid: 6c223de8-88ee-4e4e-ad30-1694d8da42e8
secrets:
- name: collection-sumologic-otelcol-logs-collector-token-98q7n

@kasia-kujawa kasia-kujawa force-pushed the kk-fix-otellogs-image-pull-secrets branch from 3643a3e to ff29c5a Compare April 13, 2023 11:53
@swiatekm
Copy link

Shouldn't we just use the common imagePullSecrets setting everything else uses instead of adding a new one?

@kasia-kujawa kasia-kujawa force-pushed the kk-fix-otellogs-image-pull-secrets branch 3 times, most recently from d51eae1 to c8a1974 Compare April 13, 2023 13:08
@kasia-kujawa kasia-kujawa changed the title fix(otellogs): add option to configure imagePullSecrets for otellogs daemonset fix(otellogs): configure imagePullSecrets for otellogs daemonset Apr 13, 2023
@kasia-kujawa kasia-kujawa force-pushed the kk-fix-otellogs-image-pull-secrets branch from c8a1974 to df07ea6 Compare April 13, 2023 13:22
@kasia-kujawa kasia-kujawa marked this pull request as ready for review April 13, 2023 13:42
@kasia-kujawa kasia-kujawa requested a review from a team as a code owner April 13, 2023 13:42
@kasia-kujawa kasia-kujawa force-pushed the kk-fix-otellogs-image-pull-secrets branch 2 times, most recently from 0ebe95f to 8bf90f3 Compare April 14, 2023 10:02
@kasia-kujawa kasia-kujawa force-pushed the kk-fix-otellogs-image-pull-secrets branch from 8bf90f3 to b6580bd Compare April 14, 2023 10:03
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplicty!

@kasia-kujawa kasia-kujawa merged commit 0cb180b into main Apr 14, 2023
@kasia-kujawa kasia-kujawa deleted the kk-fix-otellogs-image-pull-secrets branch April 14, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants