Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use timestamp as message time if exists #3039

Merged
merged 2 commits into from
May 10, 2023

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented May 9, 2023

Instructs Sumo Logic to use timestamp key if it exists. It will ensure that the timestamp extraction is consistent. Auto-detection is fallback, so no behavior change is expected in case timestamp is not added to the log

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner May 9, 2023 10:58
@sumo-drosiek sumo-drosiek force-pushed the drosiek-force-to-use-timestamp branch from b4149e4 to e5a14fc Compare May 9, 2023 11:00
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-force-to-use-timestamp branch from e5a14fc to 172c2d6 Compare May 9, 2023 11:13
@rnishtala-sumo
Copy link
Contributor

rnishtala-sumo commented May 9, 2023

Looks like one of the tests is failing

Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -9,2 +9,6 @@
        	            	     collector_id = sumologic_collector.collector.id
        	            	+    default_date_formats {
        	            	+      format  = "epoch"
        	            	+      locator = "\"timestamp\":(\\d+)"
        	            	+    }
        	            	 }
        	            	@@ -14,2 +18,6 @@
        	            	     collector_id = sumologic_collector.collector.id
        	            	+    default_date_formats {
        	            	+      format  = "epoch"
        	            	+      locator = "\"timestamp\":(\\d+)"
        	            	+    }
        	            	 }

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-force-to-use-timestamp branch from fc29f44 to fe749ca Compare May 9, 2023 13:12
@sumo-drosiek sumo-drosiek merged commit 59873c5 into main May 10, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-force-to-use-timestamp branch May 10, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants