Reordering HPA spec.metrics to match HPA ordering #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@poblahblahblah Thanks for the PR! Seems that templates are not generated correctly. Probably there is now newline rendered because of |
|
It's a bit concerning that template tests don't catch this. We should have a test that unmarshals all the templates into proper K8s objects to check for structural issues like this one. Right now, the tests use Unstructured, which is just a glorified map with metadata. |
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginxinc/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
poblahblahblah
force-pushed
the
address-argocd-hpa-reordering-issue
branch
from
7b06a4f to
82f149d
Compare
|
Ooof, good catch @sumo-drosiek Fixed and pushed. Tested again and |
|
@poblahblahblah can you add a changelog entry as per https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/docs/dev.md#adding-a-changelog-entry? |
swiatekm
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD.
Originally reported to the ArgoCD project here:
argoproj/argo-cd#1079
Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099
Other projects and companies have also addressed this by simply reordering the metrics section:
Checklist