Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics/collector): drop scrape_* metrics #3131

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Jul 4, 2023

By default, Prometheus receiver emits scrape metrics for each target, similar to Prometheus' up. We don't have these for Prometheus, so we should drop them by default for backwards compatibility.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@swiatekm swiatekm requested a review from a team as a code owner July 4, 2023 13:54
@swiatekm swiatekm merged commit cab976b into main Jul 5, 2023
@swiatekm swiatekm deleted the fix/metrics/collector-drop-scrapes branch July 5, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants