Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(prometheus): Added a section on prometheus sharding #3140

Merged
merged 1 commit into from
Jul 13, 2023
Merged

docs(prometheus): Added a section on prometheus sharding #3140

merged 1 commit into from
Jul 13, 2023

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented Jul 7, 2023 •
edited
Loading

Added a section on prometheus sharding

  • Changelog updated or skip changelog label added
  • Documentation updated

@github-actions github-actions bot added the documentation documentation label Jul 7, 2023
@rnishtala-sumo rnishtala-sumo force-pushed the scaling-prometheus branch 2 times, most recently from e667784 to 34971c3 Compare July 10, 2023 14:42
@rnishtala-sumo rnishtala-sumo marked this pull request as ready for review July 10, 2023 14:42
@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner July 10, 2023 14:42
@rnishtala-sumo rnishtala-sumo force-pushed the scaling-prometheus branch 2 times, most recently from 267f24f to 3fe9f3e Compare July 12, 2023 14:09
swiatekm
swiatekm suggested changes Jul 12, 2023
View reviewed changes
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention that this will cause recording rule metrics which require global aggregations to stop working - and with them, possibly the Kubernetes App.

@rnishtala-sumo rnishtala-sumo requested a review from swiatekm July 13, 2023 14:55
@rnishtala-sumo rnishtala-sumo merged commit 73c55b3 into main Jul 13, 2023
@rnishtala-sumo rnishtala-sumo deleted the scaling-prometheus branch July 13, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@kasia-kujawa kasia-kujawa kasia-kujawa approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnishtala-sumo @sumo-drosiek @kasia-kujawa @swiatekm