Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about version flag for helm upgrade #320

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

rvmiller89
Copy link
Contributor

Description

Since this caused some confusion when trying to set a value and seeing my Helm chart actually be downgraded to the last release version.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvmiller89 rvmiller89 merged commit e289732 into master Nov 26, 2019
@rvmiller89 rvmiller89 deleted the rvmiller89-patch-1-1 branch November 26, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants