Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): move filtering app metrics to metadata layer #3232

Merged
merged 6 commits into from
Sep 19, 2023
Merged

feat(metrics): move filtering app metrics to metadata layer #3232

merged 6 commits into from
Sep 19, 2023

Conversation

aboguszewski-sumo
Copy link
Contributor

Do not merge before v4, as this would be a breaking change in v3.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@aboguszewski-sumo aboguszewski-sumo added this to the v4.0 milestone Aug 25, 2023
@aboguszewski-sumo aboguszewski-sumo requested a review from a team as a code owner August 25, 2023 12:06
github-actions[bot]
github-actions bot requested changes Aug 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

@aboguszewski-sumo aboguszewski-sumo force-pushed the ab-move-filtering-app-metrics branch from 70327df to 6e05305 Compare August 25, 2023 12:07
@swiatekm swiatekm force-pushed the ab-move-filtering-app-metrics branch from 6e05305 to 2c97a5d Compare September 18, 2023 15:28
@swiatekm swiatekm force-pushed the ab-move-filtering-app-metrics branch 2 times, most recently from e1ac47d to d56c129 Compare September 18, 2023 16:44
@github-actions github-actions bot added the documentation documentation label Sep 18, 2023
@swiatekm swiatekm force-pushed the ab-move-filtering-app-metrics branch from 947d234 to 257bfc1 Compare September 18, 2023 17:13
@swiatekm swiatekm force-pushed the ab-move-filtering-app-metrics branch from 257bfc1 to 2e5a52a Compare September 19, 2023 08:56
@swiatekm swiatekm force-pushed the ab-move-filtering-app-metrics branch from 33a6952 to c541e16 Compare September 19, 2023 09:33
@swiatekm swiatekm merged commit d406476 into main Sep 19, 2023
33 checks passed
@swiatekm swiatekm deleted the ab-move-filtering-app-metrics branch September 19, 2023 09:49
@swiatekm swiatekm mentioned this pull request Sep 22, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
documentation documentation integration-tests
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aboguszewski-sumo @sumo-drosiek @swiatekm