1.14+-fixes-support #344
Merged
1.14+-fixes-support #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rvmiller89
approved these changes
Dec 19, 2019
| @@ -0,0 +1,183 @@ | |||
| # This file is auto-generated. | |||
There was a problem hiding this comment.
@vsinghal13 was this missed before? Should be OK to check in with this unrelated PR though?
There was a problem hiding this comment.
The file was added in the autoscaler PR.
There was a problem hiding this comment.
In this PR, the overrides section seems to be covering all the config?
|
Huh, there are conflicts for |
samjsong
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps falco to 1.0.11 (tested on non managed k8s 1.16, EKS 1.14).It also ensures that we always render the pre 1.14 rules that our apps depend on. This is a short term fix to fix missing metrics that the K8s apps depend on while we plan the long term fix of supporting mixins.
Testing performed