fix missing aggregate container metrics #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
approved these changes
Jan 9, 2020
samjsong
approved these changes
Jan 9, 2020
vsinghal13
deleted the
vsinghal-fix-missing-aggregate-container-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #345 , we had made a change to drop the duplicate metrics which did not have the container name. Few metrics eg.
container_network_receive_bytes_totalcontainer_network_transmit_bytes_totalcontainer_network_receive_errors_totalcontainer_network_transmit_errors_totalcontainer_network_receive_packets_dropped_totalcontainer_network_transmit_packets_dropped_totalThe above metrics are cumulative container metrics and do not have the container name.
This PR adds a new remote write section with these metrics.
Testing performed