Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus fix for k8s 1.16 #370

Merged
merged 4 commits into from
Jan 17, 2020
Merged

Prometheus fix for k8s 1.16 #370

merged 4 commits into from
Jan 17, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Jan 17, 2020 •
edited
Loading

Description

Relabel metrics metadata "container_name" to "container" for k8s 1.16

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

samjsong
samjsong approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks Vijit!

@vsinghal13 vsinghal13 merged commit b259728 into master Jan 17, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-prometheus-1.16-fix branch January 17, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@rvmiller89 rvmiller89 rvmiller89 approved these changes

@frankreno frankreno Awaiting requested review from frankreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsinghal13 @rvmiller89 @samjsong