Add back and expose source category for events source #377
Conversation
| @@ -85,6 +85,10 @@ sumologic: | |||
| # If enabled, collect K8s events | |||
| eventCollectionEnabled: true | |||
|
|
|||
| events: | |||
There was a problem hiding this comment.
should we move eventCollectionEnabled under this, maybe as:
events:
collectionEnabled: true
sourceCategory: ""
?
There was a problem hiding this comment.
this will be changed after #349
There was a problem hiding this comment.
I'm confused, #349 is already merged
There was a problem hiding this comment.
oh sorry wrong one, it is #330, specifically this change
There was a problem hiding this comment.
Great, thanks for confirming
| @@ -85,6 +85,10 @@ sumologic: | |||
| # If enabled, collect K8s events | |||
| eventCollectionEnabled: true | |||
|
|
|||
| events: | |||
| # Source category for the Events source. Default: "{clusterName}/events" | |||
| sourceCategory: "" | |||
There was a problem hiding this comment.
why not use what we had below to set the default sourceCategory: "%{namespace}/%{pod_name}"
There was a problem hiding this comment.
I am using the source category we had for events before for consistency. Also what would pod name be in this case? For logs it's the name of the pod that logs are coming from I assume, but events are not only about pods. We can't use the pod name of the events pod itself either, since we don't know the pod name at the time of the source creation in TF
Description
Since the events data doesn't go through metadata enrichment plugin currently, the source category for events source is just the default
httpafter we removed static source category for all sources in #349.This PR adds it back just for events source and expose it in values.yaml file. Since after Sam's breaking change, all events configuration fields go under
eventsI am adding it here in case this goes out in a minor release before the major one to avoid one more rename that customer needs to do when we do make the major release.Testing performed
helm templateto verify overwriting the field