fix(logs): do not add exporters mutliple times to the pipeline #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2024 12:09
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
|
I tested it locally and it is cosmetic change as it shouldn't lead to data duplication or any other issue, but we definitely shouldn't have this duplicates as the behavior may change in the future |
kasia-kujawa
approved these changes
Jul 5, 2024
chan-tim-sumo
pushed a commit
that referenced
this pull request
Jul 10, 2024
* fix(logs): do not add exporters mutliple times to the pipeline Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * chore: tests Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * chore: changelog Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
|
sorry about that, i might've went on this commit by accident, i don't think it messed anything up on this PR 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(logs): do not add exporters mutliple times to the pipeline
Checklist