Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kube-state-metrics to 2.14.0 #3865

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

echlebek
Copy link
Contributor

@echlebek echlebek commented Dec 17, 2024

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
@echlebek echlebek self-assigned this Dec 17, 2024
@echlebek echlebek requested a review from a team as a code owner December 17, 2024 21:25
@ccressent
Copy link

The upgrade looks fine, but have you checked that there are no important or even breaking changes since 2.7? I know it's "only" minor versions, but you'd be surprised how many components use very loose definitions of semver 😅

Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
@echlebek
Copy link
Contributor Author

@ccressent There are no advertised breaking changes, so hopefully all goes well. There have been many, many bug fixes, if one of them breaks something for someone, we will likely have to work around it.

Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
@echlebek
Copy link
Contributor Author

@ccressent Looks like all did not go well, but it's because our chart is pulling kube-state-metrics out of our own ECR. I have no idea why it's doing that but it seems related to some openshift incompatibility.

@@ -1098,7 +1098,7 @@ kube-prometheus-stack:
## so we bump the image manually.
image:
repository: public.ecr.aws/sumologic/kube-state-metrics
tag: "v2.7.0"
tag: "v2.14.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to test with this version on a vagrant box or using kind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnishtala-sumo I can do that once I get the integration tests passing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, LGTM!

@echlebek echlebek merged commit a41ec9a into main Dec 18, 2024
64 checks passed
@echlebek echlebek deleted the upgrade-kube-state-metrics-214 branch December 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants