-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade kube-state-metrics to 2.14.0 #3865
Conversation
Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
The upgrade looks fine, but have you checked that there are no important or even breaking changes since 2.7? I know it's "only" minor versions, but you'd be surprised how many components use very loose definitions of semver 😅 |
Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
@ccressent There are no advertised breaking changes, so hopefully all goes well. There have been many, many bug fixes, if one of them breaks something for someone, we will likely have to work around it. |
Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
@ccressent Looks like all did not go well, but it's because our chart is pulling kube-state-metrics out of our own ECR. I have no idea why it's doing that but it seems related to some openshift incompatibility. |
@@ -1098,7 +1098,7 @@ kube-prometheus-stack: | |||
## so we bump the image manually. | |||
image: | |||
repository: public.ecr.aws/sumologic/kube-state-metrics | |||
tag: "v2.7.0" | |||
tag: "v2.14.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to test with this version on a vagrant box or using kind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnishtala-sumo I can do that once I get the integration tests passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this, LGTM!
Checklist