Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use yq in build script to generate overrides yamls #421

Merged
merged 2 commits into from
Feb 14, 2020
Merged

use yq in build script to generate overrides yamls #421

merged 2 commits into from
Feb 14, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Feb 14, 2020 •
edited
Loading

Description

Use yq in build script to generate overrides yamls

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

vsinghal13
vsinghal13 commented Feb 14, 2020
View reviewed changes
Copy link
Contributor Author

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yq reader does not indent the yaml list items to the inner level but, it is still a valid yaml. The same is reflected in the changes in the *overrides.yaml.

rvmiller89
rvmiller89 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@rvmiller89 rvmiller89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! glad to hear they support comments now, and thanks for checking to unblock us

@vsinghal13 vsinghal13 merged commit 6162dba into master Feb 14, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-yq-build-script branch February 14, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvmiller89 rvmiller89 rvmiller89 approved these changes

@samjsong samjsong Awaiting requested review from samjsong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsinghal13 @rvmiller89