Fix fluentd zipkin json parsing #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-rumian
approved these changes
Feb 20, 2020
| @@ -3,7 +3,8 @@ receivers: | |||
| jaeger: | |||
| protocols: | |||
| grpc: | |||
| zipkin: {} | |||
| zipkin: | |||
| endpoint: "0.0.0.0:9411" | |||
There was a problem hiding this comment.
I think we could check if hostname name from values.yaml will work in this place.
There was a problem hiding this comment.
I could use {{ printf "%s-otelcol" (include "sumologic.fullname" .) }}, but it will be easy to omit while updating collector name :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIx fluent json parsing
Fix zipkin receiver port exposition
Testing performed