Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.0] change default DB path for fluentbit #450

Merged
merged 2 commits into from
Mar 24, 2020
Merged

[1.0.0] change default DB path for fluentbit #450

merged 2 commits into from
Mar 24, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Feb 26, 2020 •
edited
Loading

Description

Fluent bit uses a DB to keep track of monitored files and offsets. This PR modifies the default DB path which is specified in the fluent-bit helm chart to avoid having database error in case a user already has fluent-bit installed in the cluster with the default DB path.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from frankreno and samjsong and removed request for frankreno February 26, 2020 17:59
frankreno
frankreno approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - However I suspect that with this change, a customer could get a spike in logs when they upgrade. Lets test this and confirm this behavior...

sumo-drosiek
sumo-drosiek approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

perk-sumo
perk-sumo approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samjsong samjsong changed the title change default DB path for fluentbit [1.0.0] change default DB path for fluentbit Mar 4, 2020
@samjsong
Copy link
Contributor

samjsong commented Mar 4, 2020

since this is easily configurable in values.yaml, let's hold on merging until after major release (or with the major release, if it can cause a spike in logs due to re-ingestion).

@perk-sumo perk-sumo added this to the v1.0 milestone Mar 5, 2020
@vsinghal13 vsinghal13 merged commit 8c8e961 into master Mar 24, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-change-default-db-path-fluent-bit branch March 24, 2020 16:46
@samjsong
Copy link
Contributor

Did we ever confirm whether this will lead to duplicate ingest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@samjsong samjsong samjsong approved these changes

@frankreno frankreno frankreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vsinghal13 @samjsong @frankreno @sumo-drosiek @perk-sumo