-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "revert all 1.0.0 changes" #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, could we strip all spaces before endline?
I thought about it and I think maybe let's not do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some minor things
kubelet: | ||
outputConf: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samjsong do you want to add the enabled
flags for the log types in this PR itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's include these in a separate PR if we choose to do this 👍
|
||
## Systemd log configuration | ||
systemd: | ||
outputConf: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same enabled
flag
ee5f99f
to
fe72b93
Compare
2bf5388
to
ea257ba
Compare
@perk-sumo It would be easier to review if you not use force-push, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
15941f2
to
6b18b1b
Compare
If you use the https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/509/files and check the files you've already seen as |
Rebases. It explains everything 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Perk!
This reverts commit f25e71f.
94d491e
to
9d8ad95
Compare
This reverts commit f25e71f.
Description
All the changes added to master since the revert:
https://github.com/SumoLogic/sumologic-kubernetes-collection/compare/3cdc6acd716cfa8a003dcb78948991d5dbe58d1a..revert-the-1.0-revert
This ^^ should show all the changes added in the meantime.
Please double check nothing is missing and nothing got reverted.
Testing performed