Added another example for filtering metrics #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you please check the syntax that I put in?
vsinghal13
requested review from
vsinghal13,
drduke1,
samjsong and
perk-sumo
and removed request for
vsinghal13
vsinghal13
approved these changes
Mar 26, 2020
deploy/docs/Best_Practices.md
Outdated
| The above section should be added in each of the kube-state remote write blocks. |
There was a problem hiding this comment.
"the above section" should be "the section above". You could remove extra space before "kube-state"
deploy/docs/Best_Practices.md
Outdated
| The above section should be added in each of the kube-state remote write blocks. | ||
|
|
||
| Here is another example of excluding up metrics in the sumologic namespace and keep the up metrics for all other namespaces: |
There was a problem hiding this comment.
suggest you change "and keep the up metrics" to "while still collecting up metrics". (unless I misunderstand)
vsinghal13
added a commit
that referenced
this pull request
Mar 30, 2020
* Added another example for filtering metrics Can you please check the syntax that I put in? * Update Best_Practices.md * Update Best_Practices.md Co-authored-by: Vijit Singhal <56007827+vsinghal13@users.noreply.github.com>
vsinghal13
added a commit
that referenced
this pull request
Mar 31, 2020
* Added another example for filtering metrics Can you please check the syntax that I put in? * Update Best_Practices.md * Update Best_Practices.md Co-authored-by: Vijit Singhal <56007827+vsinghal13@users.noreply.github.com>
vsinghal13
added a commit
that referenced
this pull request
Mar 31, 2020
* Added another example for filtering metrics Can you please check the syntax that I put in? * Update Best_Practices.md * Update Best_Practices.md Co-authored-by: Vijit Singhal <56007827+vsinghal13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you please check the syntax that I put in?
Description
Fill in your description here.
Testing performed