Allow to install plugins in docker image #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsinghal13
approved these changes
Mar 31, 2020
perk-sumo
reviewed
Apr 1, 2020
deploy/docker/entrypoint.sh
Outdated
| @@ -25,4 +25,13 @@ if [ "$1" = "fluentd" ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| # Install custom plugins if specified by user | |||
| if [ -n "${ADDITIONAL_PLUGINS}" ] | |||
| then | |||
There was a problem hiding this comment.
Please follow the https://google.github.io/styleguide/shellguide.html#loops
Put ; do and ; then on the same line as the while, for or if.
It'll also be consistent throughout the file this way.
perk-sumo
approved these changes
Apr 1, 2020
sumo-drosiek
force-pushed
the
drosiek-install-custom-plugins
branch
from
b251aff to
69f2170
Compare
sumo-drosiek
force-pushed
the
drosiek-install-custom-plugins
branch
2 times, most recently
from
f864765 to
73324fc
Compare
|
@drduke1 I updated documentation related to code changes. Could you take a look? :) |
sumo-drosiek
force-pushed
the
drosiek-install-custom-plugins
branch
from
73324fc to
65f6d20
Compare
drduke1
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to install plugins basing on values.yaml
Solves #139 for simple plugins (which do not require additional libraries)
Testing performed