-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.0] expose override raw conf for container log pipeline #556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks ok, but we need to document this properly. I see some threats:
|
@@ -1,3 +1,4 @@ | |||
{{ if .Values.fluentd.logs.kubelet.enabled }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -29,6 +30,8 @@ | |||
</buffer> | |||
</match> | |||
</label> | |||
{{- end}} | |||
{{ if .Values.fluentd.logs.systemd.enabled }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add it to 1.0.0 :)
Description
This is similar to the way that Fluent-bit exposes their config. They have the option to set configs, but also to override entire sections if needed.
Here are two of the use-cases we want to solve with this new
fluentd.logs.containers.overrideRawConfig
:copy
plugin in the output)<filter containers.**>
to<filter containers.** custom.**>
, which will allow for the custom logs with the custom tag to also go through this pipeline. In the case that their log files are named in a different format than the default docker logs files, they can also update the relevant regexes to accommodate that.The idea here is to enable users to customize the part of the fluentd pipeline that is most conducive to customizations, with the clear indication that by doing so, they are overriding the default pipeline and that therefore not every custom change can be tested and supported. We'll document examples on how to achieve certain behavior (like the above), but anything else will be at the user's discretion.
(also I added the
enabled
flag for systemd and kubelet logs as a feature request from a previous github issue)Testing performed