Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing metrics #56

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Fix missing metrics #56

merged 5 commits into from
Jun 28, 2019

Conversation

samjsong
Copy link
Contributor

During testing we found the following metrics were missing:

  • cloudprovider_.*_api_request_duration_seconds.*
    • this was due to the job changing from kube-controller-manager to kubelet
  • container_memory_swap
    • this was due to a bug in the regex
  • container_spec_.*
    • this was due to trying to add multiple regex matchers in the same writeRelabelConfigs section, which I believe is piped and therefore the metrics were being dropped
  • node_memory_Free_bytes
    • this metric was renamed to node_memory_MemFree_bytes and node_memory_SwapFree_bytes

cc @ggarg2906sumo

@samjsong samjsong requested review from maimaisie and yuting-liu June 27, 2019 23:39
@Gourav2906
Copy link
Contributor

Gourav2906 commented Jun 28, 2019

@samjsong please update metrics list document also with the updated list.

@samjsong
Copy link
Contributor Author

@ggarg2906sumo done, thanks for the reminder!

@samjsong samjsong merged commit 68fa6b7 into master Jun 28, 2019
@samjsong samjsong deleted the ssong-missing-metrics branch June 28, 2019 21:24
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
* fix-slack

* Update .drone.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants