Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include serviceaccount in the usage description #590

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Include serviceaccount in the usage description #590

merged 1 commit into from
Apr 27, 2020

Conversation

pmm-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmm-sumo pmm-sumo changed the title Use serviceaccount in the usage description Include serviceaccount in the usage description Apr 24, 2020
@sumo-drosiek
Copy link
Contributor

Keep in mind that it can be deployment when the serviceaccount is not a collection-sumologic as it can be overwritten in configuration

perk-sumo
perk-sumo approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo merged commit d89cd87 into master Apr 27, 2020
@perk-sumo perk-sumo deleted the tools-command-usage branch April 27, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmm-sumo @sumo-drosiek @perk-sumo @pmaciolek