Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose resource config for prometheus node-exporter and kube state metrics. #593

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

vsinghal13
Copy link
Contributor

Expose resource config for prometheus node-exporter and kube state metrics.

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Expose resource config for prometheus node-exporter and kube state metrics.
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we have confirmed that there weren't any defaults already set for these in the prometheus chart

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming these are the respective defaults form the sub-chart.

@vsinghal13 vsinghal13 merged commit d43aef0 into master Apr 24, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-patch-1 branch April 24, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants