-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade script fixes #613
Merged
Merged
Upgrade script fixes #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perk-sumo
force-pushed
the
upgrade-script-fixes
branch
2 times, most recently
from
May 6, 2020 11:14
081dd9f
to
e4bc905
Compare
samjsong
approved these changes
May 6, 2020
vsinghal13
approved these changes
May 6, 2020
frankreno
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
perk-sumo
force-pushed
the
upgrade-script-fixes
branch
from
May 6, 2020 17:41
ed148df
to
939965d
Compare
command -v ${command_to_check} >/dev/null 2>&1 || { echo >&2 "Required command is missing: ${command_to_check}"; echo >&2 "Please consult --help and install missing commands before continue. Aborting."; exit 1; } | ||
} | ||
|
||
check_required_command yq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: yq should be in exactly 3.2.1 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fill in your description here.
Testing performed