Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade script fixes #613

Merged
merged 4 commits into from
May 6, 2020
Merged

Upgrade script fixes #613

merged 4 commits into from
May 6, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo marked this pull request as draft May 6, 2020 10:28
@perk-sumo perk-sumo force-pushed the upgrade-script-fixes branch 2 times, most recently from 081dd9f to e4bc905 Compare May 6, 2020 11:14
@perk-sumo perk-sumo marked this pull request as ready for review May 6, 2020 11:35
@perk-sumo perk-sumo added this to the v1.0 milestone May 6, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo force-pushed the upgrade-script-fixes branch from ed148df to 939965d Compare May 6, 2020 17:41
@perk-sumo perk-sumo merged commit 939965d into master May 6, 2020
@perk-sumo perk-sumo deleted the upgrade-script-fixes branch May 6, 2020 17:48
command -v ${command_to_check} >/dev/null 2>&1 || { echo >&2 "Required command is missing: ${command_to_check}"; echo >&2 "Please consult --help and install missing commands before continue. Aborting."; exit 1; }
}

check_required_command yq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: yq should be in exactly 3.2.1 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants