Parameterize resource name to support watching other resources in events plugin #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsong
reviewed
Jul 3, 2019
rvmiller89
reviewed
Jul 3, 2019
|
@rvmiller89 Yes we probably should. @yuting-liu If you are working on tests for watching events, let's add one for another resource type for example pods |
|
Sure. I'd go ahead adding one test case for this. |
samjsong
reviewed
Jul 3, 2019
samjsong
approved these changes
Jul 3, 2019
yuting-liu
reviewed
Jul 3, 2019
|
I didn't update |
rvmiller89
approved these changes
Jul 5, 2019
|
@ggarg2906sumo FYI, after this PR is merged you'll be able to watch events for a specific resource type in K8s. We want to make sure to cover that in testing |
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* adding back in ad * Add enable_ad variable to resources * Missed enable_ad arg in a couple places * and one more * Don't hard code the variable value because duh * Remove auto_gid * Don't set enable_ad in collectors because it has a default * Format terraform * Add enable_ad to root dir * does this still work? * tf fmt Co-authored-by: Malcolm Jones <17786500+mlclmj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new config param
resource_nameto take in a resource name to watch, defaulted toevents. Use the same config map to store per-resource RV using key in theresource-version-<resource-name>format.Minor change: rename
apiVersiontoapi_versionto follow the convention of other config param naming.FYI @rvmiller89 @lei-sumo