Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add baseImage for thanos #650

Merged
merged 2 commits into from
May 20, 2020
Merged

add baseImage for thanos #650

merged 2 commits into from
May 20, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented May 19, 2020 •
edited
Loading

Description

Fixes #639

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.0 milestone May 19, 2020
samjsong
samjsong approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I believe this will need to be backported as well?

frankreno
frankreno approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek mentioned this pull request May 20, 2020
Closed
perk-sumo
perk-sumo approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo merged commit f372024 into master May 20, 2020
@perk-sumo perk-sumo deleted the vsinghal13-thanos-baseImage branch May 20, 2020 10:41
@perk-sumo perk-sumo mentioned this pull request May 20, 2020
Merged
3 tasks
@perk-sumo
Copy link
Contributor

I've created a PR for v0.17
#655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@samjsong samjsong samjsong approved these changes

@frankreno frankreno frankreno approved these changes

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

values.yaml referencing thanos v0.10.0 is deprecated
4 participants
@vsinghal13 @perk-sumo @frankreno @samjsong