Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus operator helm chart #667

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we spot some suspicious changes? Thats a lot of versions 🙀

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumo-drosiek I think the request from Frank was to verify and bump up all of our dependency chart versions to latest if possible, LGTM assuming we sanity checked - we can run more extensive verification pre-release

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samjsong That makes sense. LGTM then :)

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankreno
Copy link
Contributor

@sumo-drosiek I did a sanity check of the release changes in the versions and I did not spot anything that looked suspicious. However, we can bump, allow e2e to run, and then sanity check the apps as well to confirm.

@perk-sumo perk-sumo changed the base branch from master to release-v1.1 May 25, 2020 11:40
Update prometheus operator helm chart
@perk-sumo perk-sumo force-pushed the vsinghal13-prom-helm-update branch from d052360 to 3293cd5 Compare May 25, 2020 11:41
@perk-sumo perk-sumo changed the base branch from release-v1.1 to master May 25, 2020 11:56
@vsinghal13 vsinghal13 merged commit 24e77f0 into master May 26, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-prom-helm-update branch May 26, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants