Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collectionMonitoring logic #682

Merged
merged 9 commits into from
May 28, 2020
Merged

Conversation

vsinghal13
Copy link
Contributor

Description

Fixes #211.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.1 milestone May 26, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sumo-drosiek
Copy link
Contributor

sumo-drosiek commented May 27, 2020

Is there way to exclude by pod labels? It would be more kubernetes way

I don't feel confident with excluding by namespace name in regex, because it can provide a lot of edge cases

Except for that question, LGTM :)

@vsinghal13
Copy link
Contributor Author

Is there way to exclude by pod labels? It would be more kubernetes way

I don't feel confident with excluding by namespace name in regex, because it can provide a lot of edge cases

Except for that question, LGTM :)

I could not find a way to exclude via pod labels.

@perk-sumo perk-sumo merged commit 7d049b9 into master May 28, 2020
@perk-sumo perk-sumo deleted the vsinghal-collection-monitoring-flag branch May 28, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we default the collection process to exclude Sumologic Logs
4 participants