Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator for logs, events and traces sources #708

Merged
merged 6 commits into from
Jun 8, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Auto-generate logs, events and traces endpoints in terraform
It doesn't add automatic usage of these sources in fluentd. It has to be done manually

This PR is made almost on the top of the #705

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek added this to the v1.1 milestone Jun 4, 2020
@sumo-drosiek sumo-drosiek force-pushed the drosiek-logs-events-traces-sources branch 2 times, most recently from 6be69f7 to 1a1ce8f Compare June 4, 2020 14:26
@sumo-drosiek sumo-drosiek changed the title Add generator for logs, events and traces Add generator for logs, events and traces sources Jun 4, 2020
@sumo-drosiek sumo-drosiek linked an issue Jun 4, 2020 that may be closed by this pull request
@perk-sumo perk-sumo force-pushed the drosiek-terraform-source-fields branch from d859b1b to 9286794 Compare June 4, 2020 15:19
Base automatically changed from drosiek-terraform-source-fields to master June 4, 2020 15:33
@sumo-drosiek sumo-drosiek force-pushed the drosiek-logs-events-traces-sources branch from 1a1ce8f to 413dc41 Compare June 4, 2020 15:41
@sumo-drosiek sumo-drosiek force-pushed the drosiek-logs-events-traces-sources branch 3 times, most recently from 6d1b64c to 7bfc4e5 Compare June 5, 2020 06:00
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome stuff

@sumo-drosiek
Copy link
Contributor Author

Forgot about upgrading docker image

@@ -39,6 +39,8 @@ spec:
env:
- name: GOGC
value: "80"
{{- $ctx := .Values -}}
{{ include "fluentd.envs" (dict "Context" $ctx "Type" "traces")}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we call it flutend.envs if we use it for otelcol as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we didn't use it for otelcol before 😅

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos!
Except for one comment it's a 👍. I like how you've split this into separate commits.

@sumo-drosiek sumo-drosiek force-pushed the drosiek-logs-events-traces-sources branch from 5eb17ab to 004db9a Compare June 5, 2020 11:46
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sumo-drosiek sumo-drosiek force-pushed the drosiek-logs-events-traces-sources branch from fe2ce8a to 161345a Compare June 8, 2020 08:27
@sumo-drosiek
Copy link
Contributor Author

Close and reopen due to ci

@sumo-drosiek sumo-drosiek reopened this Jun 8, 2020
@sumo-drosiek sumo-drosiek merged commit d68ccf7 into master Jun 8, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-logs-events-traces-sources branch June 8, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dynamic generations of events and logs source endpoints
3 participants