Severity1 fix 741 #745
Merged
Severity1 fix 741 #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, Thank you for the PR 👍 |
sumo-drosiek
approved these changes
Jun 25, 2020
|
@severity1 Just one ask, could you squash the commits please? |
perk-sumo
approved these changes
Jun 25, 2020
|
@sumo-drosiek let's use the |
|
thanks team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally in helm the namespace is created automatically or beforehand, in most cases organizations will want to add metadata to their namespace for auditing and automating purposes. Sumologic's helm setup job makes this impossible as it recreates the namespace thus removing all the metadata added beforehand. This PR's intention is to remove this responsibility from sumologic's helm.