Cleanup Dockerfile and remove Dockerfile-debian #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
commented
Jul 18, 2019
deploy/docker/Dockerfile
Outdated
| @@ -26,9 +27,8 @@ RUN gem install fluent-plugin-s3 -v 1.1.4 \ | |||
| && gem install fluent-plugin-prometheus -v 1.1.0 \ | |||
| && gem install fluent-plugin-kubernetes_sumologic | |||
There was a problem hiding this comment.
actually, is this correct? Are we missing a version here? In fact, are we using this gem anywhere? This is https://github.com/SumoLogic/fluentd-kubernetes-sumologic, right?
There was a problem hiding this comment.
I missed that, you are right. We should include the version explicitly. WE are using it
There was a problem hiding this comment.
Why are we using this gem? This is the fluend daemonset which should be removed from here as we have fluentbit now.
lei-sumo
reviewed
Jul 19, 2019
deploy/docker/Dockerfile
Outdated
| @@ -26,9 +27,8 @@ RUN gem install fluent-plugin-s3 -v 1.1.4 \ | |||
| && gem install fluent-plugin-prometheus -v 1.1.0 \ | |||
| && gem install fluent-plugin-kubernetes_sumologic | |||
There was a problem hiding this comment.
Why are we using this gem? This is the fluend daemonset which should be removed from here as we have fluentbit now.
lei-sumo
approved these changes
Jul 19, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Update existing roles and users * Remove 2fa and guest roles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're no longer using
fluent-plugin-carbon-v2so we can skip installing that (although our CI script will still build the gem since the directory is in this repo).We were also installing the local
fluent-plugin-sumologic_outputover the gem file from RubyGems, so this removes that extra replacement.Lastly we want to focus on Dockerfile and remove Dockerfile-debian.