-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the indentation of the processing rule example #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! But let's keep the comment hashes at the same level as this needs to be uncommented as a whole block.
I think there should not be any spaces between the comment hash and the commented key ( |
As far as I can see (et least Nevertheless I'm all ears to hear pros and cons of both approaches. |
Actually we're using both: I like the However we chose we should make it clear at the top, like I propose in this PR for comments starting with |
I've created new issue for |
Co-authored-by: Marcin Stozek <58700054+perk-sumo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
The indentation was little off and therefore on uncommenting the code and doing helm upgrade, it was giving the YAML file error.
Fill in your description here.
Testing performed