Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom pod annotations for kube-state and prometheus #848

Merged

Conversation

pmalek-sumo
Copy link
Contributor

Description

This PR adds possibility to add custom:

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense :)

@perk-sumo perk-sumo added this to the v1.2 milestone Aug 24, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmalek-sumo pmalek-sumo merged commit 8aa071c into master Aug 24, 2020
@pmalek-sumo pmalek-sumo deleted the allow-custom-annotations-for-kube-state-and-prometheus branch August 24, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants