Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of traces config #868

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Revert removal of traces config #868

merged 2 commits into from
Aug 31, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Revert removal of traces config

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested review from mat-rumian, pmm-sumo, a team, samjsong, vsinghal13 and pmalek-sumo and removed request for a team August 31, 2020 11:10
@sumo-drosiek sumo-drosiek added this to the v1.2 milestone Aug 31, 2020
@mat-rumian
Copy link
Contributor

Checked on k8s env. Works fine 🏅

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@perk-sumo
Copy link
Contributor

@sumo-drosiek please make sure CI passes before merge.

@perk-sumo
Copy link
Contributor

Travis gives the following error:
https://travis-ci.org/github/SumoLogic/sumologic-kubernetes-collection/builds/722705120#L869

Command failed with status (1): [ruby -w -I"lib:lib:test" -I"/home/travis/.rvm/gems/ruby-2.5.3/gems/rake-12.3.3/lib" "/home/travis/.rvm/gems/ruby-2.5.3/gems/rake-12.3.3/lib/rake/rake_test_loader.rb" "test/plugin/test_filter_enhance_k8s_metadata.rb" "test/sumologic/kubernetes/test_cache_strategy.rb" "test/sumologic/kubernetes/test_connector.rb" "test/sumologic/kubernetes/test_reader.rb" "test/sumologic/kubernetes/test_service_monitor.rb" ]
/home/travis/.rvm/gems/ruby-2.5.3/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
/home/travis/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
Script error on line 54
The command "bash ci/build.sh" exited with 1.

We get the same error on master branch.

@perk-sumo perk-sumo merged commit 49dee87 into master Aug 31, 2020
@perk-sumo perk-sumo deleted the drosiek-fix-tracing branch August 31, 2020 16:20
@perk-sumo
Copy link
Contributor

CI fixed by #870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants