Relabel pod and service dimensions for non-pod metrics #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
a team,
vsinghal13,
pmalek-sumo and
perk-sumo
and removed request for
a team
frankreno
reviewed
Sep 2, 2020
| sourceLabels: [job, __name__] | ||
| - action: labelmap | ||
| regex: (pod|service) | ||
| replacement: sumo_metrics_${1} |
There was a problem hiding this comment.
Nit. sumo_metrics_ as the prefix feels unintuitive. In this case, pod and service are pointers to the pod/service that Prometheus scraped the data from. Let's change it sd_ to indicate it is part of the service discovery mechanism.
There was a problem hiding this comment.
I think we should go further and use service_discovery_${1} - no need to use the non-obvious abbreviation.
sumo-drosiek
force-pushed
the
drosiek-relabel-pod-for-unralated-metrics
branch
from
3205de6 to
740cb66
Compare
perk
reviewed
Sep 3, 2020
samjsong
approved these changes
Sep 3, 2020
Co-authored-by: Marcin Stożek <marcin.stozek@gmail.com>
sumo-drosiek
force-pushed
the
drosiek-relabel-pod-for-unralated-metrics
branch
from
6f1ea87 to
8b43864
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relabel pod and service dimensions for non-pod metrics
Testing performed