Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capture hpa metrics #884

Merged
merged 10 commits into from
Sep 11, 2020
Merged

capture hpa metrics #884

merged 10 commits into from
Sep 11, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Below mentioned hpa metrics have been added.

  • kube_horizontalpodautoscaler_metadata_generation
  • kube_horizontalpodautoscaler_spec_max_replicas
  • kube_horizontalpodautoscaler_spec_min_replicas
  • kube_horizontalpodautoscaler_status_current_replicas
  • kube_horizontalpodautoscaler_status_desired_replicas
  • kube_horizontalpodautoscaler_labels

have skipped adding kube_horizontalpodautoscaler_status_condition as it seems to have too many conditions and will increase metric cardinality.

Ref:https://github.com/kubernetes/kube-state-metrics/blob/master/docs/horizontalpodautoscaler-metrics.md

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 linked an issue Sep 3, 2020 that may be closed by this pull request
Capture HPA Metrics from Kube State Metrics #800
Closed
@vsinghal13 vsinghal13 added this to the v1.3 milestone Sep 3, 2020
@samjsong
Copy link
Contributor

samjsong commented Sep 3, 2020

Can we also add the metrics to the list in the comments?

samjsong
samjsong approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frankreno
Copy link
Contributor

frankreno commented Sep 4, 2020 •
edited
Loading

Let's actually just collect

kube_horizontalpodautoscaler_spec_max_replicas
kube_horizontalpodautoscaler_spec_min_replicas
kube_horizontalpodautoscaler_status_current_replicas
kube_horizontalpodautoscaler_status_desired_replicas

@vsinghal13 vsinghal13 merged commit 5ab5d46 into master Sep 11, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-capture-hpa-metrics branch September 11, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@frankreno frankreno Awaiting requested review from frankreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Capture HPA Metrics from Kube State Metrics
4 participants
@vsinghal13 @samjsong @frankreno @perk-sumo