Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telegraf operator helm chart to the requirements #893

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Add telegraf operator helm chart to the requirements #893

merged 1 commit into from
Sep 16, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Add telegraf operator helm chart to the requirements

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested review from frankreno, perk-sumo, a team and andrzej-stencel and removed request for a team September 9, 2020 08:33
@sumo-drosiek sumo-drosiek force-pushed the drosiek-add-telegraf-chart branch from 98d0ce3 to db02242 Compare September 14, 2020 16:12
frankreno
frankreno approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise LGTM

deploy/helm/sumologic/values.yaml Show resolved Hide resolved
vagrant/values.yaml Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-add-telegraf-chart branch 5 times, most recently from 7838831 to e4eac67 Compare September 15, 2020 13:36
@sumo-drosiek sumo-drosiek added this to the v1.3 milestone Sep 16, 2020
@sumo-drosiek sumo-drosiek force-pushed the drosiek-add-telegraf-chart branch from e4eac67 to 9d2a8aa Compare September 16, 2020 07:39
frankreno
frankreno approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek force-pushed the drosiek-add-telegraf-chart branch from 9d2a8aa to 0c59e97 Compare September 16, 2020 16:51
@sumo-drosiek sumo-drosiek force-pushed the drosiek-add-telegraf-chart branch from 0c59e97 to 6252679 Compare September 16, 2020 16:54
@sumo-drosiek sumo-drosiek merged commit 69d7464 into master Sep 16, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-add-telegraf-chart branch September 16, 2020 22:04
perk-sumo
perk-sumo reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment only, otherwise LGTM :)

deploy/helm/sumologic/values.yaml Show resolved Hide resolved
@sumo-drosiek sumo-drosiek mentioned this pull request Sep 24, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo left review comments

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@frankreno frankreno frankreno approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sumo-drosiek @frankreno @perk-sumo @pmalek-sumo