Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support openshift #925

Merged
merged 12 commits into from
Sep 21, 2020
Merged

support openshift #925

merged 12 commits into from
Sep 21, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from a team, samjsong, pmalek-sumo, andrzej-stencel, frankreno, perk-sumo and sumo-drosiek and removed request for a team September 18, 2020 02:12
frankreno
frankreno approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we will need a supplemental doc on installing open shift. Let's add to this PR.

samjsong
samjsong approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Openshift changes LGTM, but a little confused about the tests changes, is that related?

@sumo-drosiek
Copy link
Contributor

@samjsong It was for debugging purpose.
@vsinghal13 We can drop that commit

@vsinghal13 vsinghal13 merged commit cb6e8d0 into master Sep 21, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-support-openshift branch September 21, 2020 16:30
@perk-sumo perk-sumo added this to the v1.3 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@frankreno frankreno frankreno approved these changes

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@vsinghal13 @sumo-drosiek @frankreno @samjsong @perk-sumo