Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install shellcheck with apt in vagrant #945

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Sep 24, 2020

It seems that it isn't as easy as we might think:
shellcheck's snap doesn't have access to all filesystems

snap connections shellcheck
Interface        Plug                        Slot   Notes
home             shellcheck:home             :home  -
removable-media  shellcheck:removable-media  -      -

and it doesn't seem that it's easy to allow it to access (in our case) /sumologic

https://askubuntu.com/questions/1033344/how-to-give-snaps-access-to-somedir

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕

@pmalek-sumo pmalek-sumo merged commit 729004d into master Sep 24, 2020
@pmalek-sumo pmalek-sumo deleted the install-shellcheck-with-apt-in-vagrant branch September 24, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants