Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include OpenTelemetry Collector logs by default #960

Merged
merged 8 commits into from
Sep 30, 2020
Merged

Conversation

pmm-sumo
Copy link
Contributor

@pmm-sumo pmm-sumo commented Sep 28, 2020

Splits the filter commonly assigned to Fluentd and OTC into two separate filters.
For OTC, select logs with warning or error level, as well as some of the other logs
from selected components. That way we e.g. skip logging exporter logs (which could
flood the ingest)

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v1.3 milestone Sep 29, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending existing comments

pmaciolek and others added 7 commits September 30, 2020 15:44
Splits the filter commonly assigned to Fluentd and OTC into two separate filters.
For OTC, select logs with warning or error level, as well as some of the other logs
from selected components. That way we e.g. skip logging exporter logs (which could
flood the ingest)
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@perk-sumo perk-sumo merged commit e8949ae into master Sep 30, 2020
@perk-sumo perk-sumo deleted the pmaciolek-otc-logs branch September 30, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants