Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract unit tests from build.sh and run as separate build stage #974

Merged
merged 6 commits into from
Oct 13, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Extract unit tests from build.sh

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor Author

image

@sumo-drosiek sumo-drosiek changed the title [WIP] Extract unit tests from build.sh Extract unit tests from build.sh and run as separate build stage Oct 6, 2020
ci/build.sh Outdated Show resolved Hide resolved
ci/build.sh Show resolved Hide resolved
ci/build.sh Outdated Show resolved Hide resolved
ci/run-tests.sh Outdated Show resolved Hide resolved
ci/run-tests.sh Outdated Show resolved Hide resolved
ci/run-tests.sh Outdated Show resolved Hide resolved
vagrant/Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall 👍 but some comments needs answer

@sumo-drosiek sumo-drosiek force-pushed the drosiek-extract-unit-tests branch 2 times, most recently from 1803d51 to 3b033af Compare October 12, 2020 11:09
vagrant/provision.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for one comment pending (and commits history cleanup 😉 )

@pmalek-sumo
Copy link
Contributor

👍 except for one comment pending (and commits history cleanup 😉 )

No squash?

.travis.yml Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-extract-unit-tests branch from a02e5da to 26bbf4a Compare October 12, 2020 12:43
@sumo-drosiek sumo-drosiek force-pushed the drosiek-extract-unit-tests branch 2 times, most recently from 29005e2 to dc0d180 Compare October 12, 2020 13:10
@sumo-drosiek sumo-drosiek force-pushed the drosiek-extract-unit-tests branch from dc0d180 to 27134ef Compare October 12, 2020 13:19
@sumo-drosiek sumo-drosiek force-pushed the drosiek-extract-unit-tests branch from 27134ef to f764bca Compare October 13, 2020 09:16
@sumo-drosiek sumo-drosiek merged commit aefa57f into master Oct 13, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-extract-unit-tests branch October 13, 2020 09:29
@sumo-drosiek sumo-drosiek linked an issue Oct 14, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix shellcheck issues and enforce it's check
3 participants